Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into main branch rust-lang/rust? #89

Open
luojia65 opened this issue Oct 28, 2021 · 8 comments
Open

Merge into main branch rust-lang/rust? #89

luojia65 opened this issue Oct 28, 2021 · 8 comments

Comments

@luojia65
Copy link

By now developers have to compile whole custom Rust toolchain to work with xtensa isa. Is there any possibility to merge xtensa instruction set support into main branch Rust? Then developers can install them easily by using rustup toolchain add command.

@mcilloni
Copy link

I don't think this can be done until the Xtensa backend is merged into upstream LLVM, but I could be wrong.

@MabezDev
Copy link
Member

@mcilloni is correct, Rust won't accept Xtensa support upstream without atleast an experimental backend in LLVM upstream.

With the riscv chips, we've already upstreamed everything we can.

@stappersg
Copy link

Where to check the status?

URLs that I'm missing:

  • LLVM xtensa branch
  • issue that describes the merge of xtensa into LLVM
  • issue that describes the merge of "LLVM xtensa" into Rust

@MabezDev
Copy link
Member

@paulocsanz
Copy link

paulocsanz commented Feb 12, 2023

espressif/llvm-project#4 implies that all of the repo's changes have been merged to upstream LLVM, although the PR hasn't been closed yet.

What are the next steps?

@igrr
Copy link

igrr commented Feb 12, 2023

We have indeed got the first patch set merged into LLVM, however that set of patches is not yet sufficient for a working Rust compiler.
We will update the tracking issue with the next series of patches as soon as we post them for review. You can find the entire set of Xtensa patches here: espressif/llvm-project#62.

@noahbliss
Copy link

Hey guys, just wanted to ping this as it seems there is some new traction over at the tracking issue espressif/llvm-project#4 seems this might be coming pretty close

@jessebraham
Copy link
Member

seems this might be coming pretty close

My understanding (somebody can correct me if I'm wrong) is that there are still a large number of patches which need to be merged into LLVM before full Xtensa support is realized. Once this is complete, it will take time for these changes to propagate into Rust as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants