Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training update #152

Merged
merged 122 commits into from
Mar 17, 2023
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Mar 13, 2023

Sorry for the long PR, here is a summary:

  • Pin crates version to latest released version
    • Updated examples accordingly
    • Remove unnecessary dependencies
    • Updated the book to match the updated examples
  • Update nightly version
  • LanguageTool suggestions
  • Delete BSC
    • Created 2 crates: One for wifi and another for ws2812
  • Updated container
  • Removed icm42670p crate, we now use https://crates.io/crates/icm42670 instead

Copy link

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few not-that-important comments.

book/src/01_intro.md Show resolved Hide resolved
intro/http-client/examples/https_client.rs Outdated Show resolved Hide resolved
intro/http-client/examples/https_client.rs Outdated Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot to digest here, but everything looks okay from a couple of passes of the changes. Thanks for taking care of this!

@SergioGasquez SergioGasquez merged commit 0692ef6 into esp-rs:main Mar 17, 2023
@SergioGasquez SergioGasquez deleted the feature/crates-update branch March 17, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the examples to use a recent version of esp-idf crates Book improvements Update board refrences
3 participants