Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update training to latest releases #257

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

SergioGasquez
Copy link
Member

No description provided.

book/src/03_5_3_mqtt.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Vollbrecht Vollbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

A couple of notes. In the book we still use the static uuid in the mqtt examples. In my testing it seams that all major broker provider somehow now blocking this uuid ;D i think just to many peole run the examples ;D If i change the topic creation to not using the uuid it works on hivemq / mosquitto / emqx. So if either the mqtt example could generate a uuid in a build.rs and write it into the cfg file or the host-client is maybe something that we could add to mitigate that problem.

@Vollbrecht
Copy link
Contributor

Two more things on the to-do list.

  • in every .cargo/config.toml -> change idf version to ESP_IDF_VERSION = { value = "tag:v5.2.2" } and remove the panic_imidate_abort for a better .unwrap/() experience.

  • in every Cargo.toml add a [[bin]] section such that rust-analyzer doesn't topple over building test's like the following.

[[bin]]
name = "hardware-check"
harness = false # We can't use the default rust libtest harness for a crosscompile target

@SergioGasquez
Copy link
Member Author

Thanks for the input @Vollbrecht! I think I addressed all the review comments but the UUID one, which can be implemented in a following PR

@Vollbrecht
Copy link
Contributor

Thanks for the input @Vollbrecht! I think I addressed all the review comments but the UUID one, which can be implemented in a following PR

Yeah the uuid thing was quite strange ;D can you actually communicate using that hard coded UUID through a public broker with the host-client and the esp? It never worked for me till i changed it.

Copy link
Contributor

@Vollbrecht Vollbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@Vollbrecht
Copy link
Contributor

also one little thing, could you co-author your first commit with juliankrieger julian.krieger@me.com as he did also some of the changes the same way but for 0.48 so we can close #243

@SergioGasquez
Copy link
Member Author

can you actually communicate using that hard coded UUID through a public broker with the host-client and the esp?

Didn't tried with a public broker, I did in the past, and it worked, but not recently.

@SergioGasquez SergioGasquez merged commit c0117c5 into esp-rs:main Jul 2, 2024
10 checks passed
@SergioGasquez SergioGasquez deleted the feature/deps branch July 2, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants