-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update training to latest releases #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
A couple of notes. In the book we still use the static uuid in the mqtt examples. In my testing it seams that all major broker provider somehow now blocking this uuid ;D i think just to many peole run the examples ;D If i change the topic creation to not using the uuid it works on hivemq / mosquitto / emqx. So if either the mqtt example could generate a uuid in a build.rs and write it into the cfg file or the host-client is maybe something that we could add to mitigate that problem.
Two more things on the to-do list.
[[bin]]
name = "hardware-check"
harness = false # We can't use the default rust libtest harness for a crosscompile target |
Thanks for the input @Vollbrecht! I think I addressed all the review comments but the UUID one, which can be implemented in a following PR |
Yeah the uuid thing was quite strange ;D can you actually communicate using that hard coded UUID through a public broker with the host-client and the esp? It never worked for me till i changed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
also one little thing, could you co-author your first commit with juliankrieger julian.krieger@me.com as he did also some of the changes the same way but for 0.48 so we can close #243 |
760f086
to
a4c563a
Compare
Co-authored-by: juliankrieger <julian.krieger@me.com>
a4c563a
to
9dbe8a3
Compare
Didn't tried with a public broker, I did in the past, and it worked, but not recently. |
No description provided.