-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESP-IDF environment activation #69
Conversation
Install ninja with apt Use arg instead of env for ESP_IDF_VERSION
Use ESP_BOARD as ARG
Hello @SergioGasquez , thanks for your contribution. 👍 Please note that #70 was merged earlier, which results in a merge conflict now. That PR fixes the Github CI workflow & reduces the resulting image size slightly. Unfortunately it also required some changes to the If you want, I can resolve the merge conflict. Once done the new CI job should then trigger automatically to test the dependencies changes within the Docker image. Please don't hesitate if you see something wrong or have suggestions how to further reduce the image size. The final image sits currently at ~3.0Gb. |
Hi @justahero! Just resolved the conflicts, please, have a look at them and let me know if you think there is anything we can improve! |
embuild
version to be at least0.28.5
esp-idf-sys
version to be at least0.31.5
embeded-sv
version to be at least0.19
idf_tools.py
(it installs the proper version for ESP-IDF)