Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly export LIBCLANG_PATH #6

Merged
merged 1 commit into from
May 30, 2022

Conversation

svenstaro
Copy link
Contributor

@svenstaro svenstaro commented May 28, 2022

Fixes #5.

This was previously reported in esp-rs#5.
@jessebraham
Copy link
Member

Sorry I'm not entirely sure I understand what's going on here (I also have not seen this error personally). Shouldn't LIBCLANG_PATH already be set by the export script? See here:

Building the export script:
https://github.com/esp-rs/rust-build/blob/main/install-rust-toolchain.sh#L504

Updating the path:
https://github.com/esp-rs/xtensa-toolchain/blob/main/install.sh#L58-L59

@jessebraham jessebraham merged commit c6833c1 into esp-rs:main May 30, 2022
@brianmay
Copy link

brianmay commented Jun 1, 2022

I think I understand. The problem is that github CI doesn't support the export script. While we do run the export script, the changes will get lost as soon as the install.sh script finishes.

We have to use the supported github mechanism for updating environment variables for future CI steps. We were doing this for $PATH but we were not doing this for $LIBCLANG_PATH which I presume is a new required value that was introduced recently.

Confirmed this change fixes the problem for me.

I note that we do not preserve the $PIP_USER environment variable either. Which is set to "NO". But so far it doesn't look like this actually causes any problems.

@HannesGitH
Copy link

for peeps coming here because they tried cargo generate --git https://github.com/esp-rs/esp-idf-template cargo and then directly cargo run, you are still using the upstream rust which has no xtensa target, you need to use the rust fork (via . ./export-esp.sh) as specified here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also export LIBCLANG_PATH
4 participants