Skip to content

Commit

Permalink
BREAKING - "i2s.h" removed, I2S library added (#8108)
Browse files Browse the repository at this point in the history
* BREAKING - "i2s.h" removed, I2S library added

An "i2S.h" header was present in prior cores, but this conflicts with the
Arduino standard I2S.h header for the I2S class under Windows (because of
case insensitivity).

Initial 3.0.0 release has a redirect "i2s.h" file in the cores directory to
redirect to the "I2S.h" file in the library, but under Windows this resulted
in the IDE not building the I2S library and link errors.

Remove the offending header.  Code will need to mode to including "I2S.h"
instead (which will include both the Arduino class as well as the low-level
definitions).

Fixes #8107

* Update examples to use proper I2S.h version
  • Loading branch information
earlephilhower authored Jun 8, 2021
1 parent e8b411f commit 2185f9b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
12 changes: 0 additions & 12 deletions cores/esp8266/i2s.h

This file was deleted.

2 changes: 1 addition & 1 deletion libraries/esp8266/examples/I2SInput/I2SInput.ino
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
*/

#include <ESP8266WiFi.h>
#include <i2s.h>
#include <I2S.h>

void setup() {
Serial.begin(115200);
Expand Down
2 changes: 1 addition & 1 deletion libraries/esp8266/examples/I2STransmit/I2STransmit.ino
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include <ESP8266WiFi.h>
#include <WiFiUdp.h>
#include <i2s.h>
#include <I2S.h>

#ifndef STASSID
#define STASSID "your-ssid"
Expand Down

0 comments on commit 2185f9b

Please sign in to comment.