Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addServiceTxt String return void not bool #1962

Closed
miky2k opened this issue Apr 22, 2016 · 3 comments
Closed

addServiceTxt String return void not bool #1962

miky2k opened this issue Apr 22, 2016 · 3 comments

Comments

@miky2k
Copy link

miky2k commented Apr 22, 2016

void addServiceTxt(String name, String proto, String key, String value){
addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
}

should be

bool addServiceTxt(String name, String proto, String key, String value){
return addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
}

I'm trying to access txt of queried services can you give me an example ?

i found only
String hostname(int idx);
IPAddress IP(int idx);
uint16_t port(int idx);
to access queried services.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@igrr
Copy link
Member

igrr commented May 10, 2016

I don't think mDNS library currently supports TXT queries. Looking at the code, only PTR queries are implemented.

@devyte
Copy link
Collaborator

devyte commented Oct 17, 2017

The referenced functions still have the wrong return type in latest git.

@devyte devyte self-assigned this Feb 8, 2018
@devyte devyte added this to the 2.5.0 milestone Feb 8, 2018
fabianoms added a commit to fabianoms/Arduino that referenced this issue Mar 13, 2018
@devyte
Copy link
Collaborator

devyte commented Jul 12, 2018

This is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants