Skip to content

OneWire and pinMode as INPUT(_PULLUP) #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jh1995 opened this issue Jun 19, 2015 · 1 comment
Closed

OneWire and pinMode as INPUT(_PULLUP) #447

jh1995 opened this issue Jun 19, 2015 · 1 comment

Comments

@jh1995
Copy link

jh1995 commented Jun 19, 2015

Since May 6th 2015, the pin chosen for OneWire communication has been changed from INPUT to INPUT_PULLUP mode. This breaks existing circuits and introduces a level of hardware randomness.

The OneWire bus specification requires a well defined pull-up resistor, 4k7. With the ESP8266 internal pullup active, the resistor value becomes chip dependant, somehow unknown and hard to define for complex installations with many 1wire slaves. Not counting that existing implementations with an external resistor need a hardware mod to work with newer code.

Please roll back the definition at line 122 in OneWire.cpp and restore pinMode as INPUT. Then add an optional parameter, a function() or a #define that lets the programmer override the default INPUT value.

Thanks.

@igrr
Copy link
Member

igrr commented Jun 26, 2015

Parameter added in esp8266-1.6.5-804-g2d340c7.

@igrr igrr closed this as completed Jul 23, 2015
igrr pushed a commit that referenced this issue Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants