Wrong #define LED_BUILTIN for NodeMCU board

[TridentTD]

Basic Infos

ESP8266 Arduino Core 2.4.1 has a mistake (?) #define LED_BUILTIN
for NodeMCU board to pin gpio16 , then when using BLINK example ,
it can't blink the LED_BUILTIN

https://github.com/esp8266/Arduino/blob/master/variants/nodemcu/pins_arduino.h#L35

It should be defined to pin gpio 2 ?

Platform

• NodeMCU 1.0 (ESP12F)
• Core version 2.4.1
• ArduinoIDE
• Windows10

Settings in IDE

• NodeMCU
• 4MB
• lwip V2 & V1.4

[NobleAscent]

This issue is previously covered but I guess they haven't decided to do anything about it. 😢

[lrmoreno007]

The official Nodemcu has the integrated led connected to the GPIO16 pin (with inverse logic by the way).

The led in GPIO2 to which you refer, is integrated into the ESP12e and this is integrated into Nodemcu. But be careful because not all ESP12e cards have this led.

Therefore, LED_BUITIN in GPIO16 is correct.

https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQMdY72MOGomZsb1h_nGYNivWbEVOq_hBC34VSR3-S0n3MWpIws

[tablatronix]

@lrmoreno007 is correct, the led on an esp12e is tied to io2/txd1 and is used for com ind, meaning it will blink if you use serial2. io16 is the correct definition for nodemcu.

[5chufti]

@devyte since defines seem to be correct, shouldn't this be closed?

[devyte]

I'm confused. My understanding is that for all boards based on the esp12 reference hw the builtin led is gpio2. Yes, it blinks when using serial2, but it also blinks e.g. with a dht22 shield on a wemos d1 r2.
I also understand that some nodemcu devices have an extra led, which is NOT called builtin, and in the case.of noddemcu it's on gpio16.
Then, the builtin define was changed from gpio2 to gpio16, which is the current state. And now there is a request to change it back, because the blink example doesn't work on that board.
So which is it? Please don't make me dig out my old nodemcu boards to answer this myself, they're somewhere behind 15 months worth of storage.

[tablatronix]

Hmm it was changed at some point?

[tablatronix]

blink works fine on nodemcu (amica), and a wemos v3 pro
maybe they are using some lolin nodemcu without a second led and using the wrong board definition.

Either way it looks fine to me ( unless we add LED_BUILTIN_2 at some point )

IMHO boards with an aux led should be mapped to LED_BUILTIN and ones without should be mapped to esp led. Sounds reasonable to me

[d-a-v]

@TridentTD @NobleAscent Could you elaborate ?
Does your nodemcu board have a led on pin 16 ?

[tablatronix]

Fyi same goes for adafruit huzzah it has 2 leds builtin defined for aux led io 0

[5chufti]

I have only cheap "replicas" of nodemcu boards but even the cheapest without ESP-12 module (esp directly on pcb w/o metal can) has both leds...

[devyte]

Are there any of these boards that don't have a led on gpio2?

[tablatronix]

Every dev board I know of uses 12e or 12f so no, but there is a lot of boards. I can start looking

[devyte]

@tablatronix If all esp12-based boards have a led on gpio2, then I'd think that led should be the builtin one. That makes it consistent and assures that the blink example will always work, putting this recurring topic to rest.
If some boards have another additional led, then those variants should have an extra define. Call it AUX, per your comment above.

If there is any variant that does not have a led on gpio2, then we can discuss further what to do.

@d-a-v any thoughts here?

[d-a-v]

@devyte
If LED_BUILTIN's working for all boards, I'm fine :)
I don't mind if leds are swapped when there are two, neither adding a LED_BUILTIN_AUX define if that's wished.

[DaleSchultz]

LED_BUILTIN does not work on my NodeMCU boards
LED_BUILTIN is defined as 16 and does not activate an LED, neither HIGH nor LOW
D4 (defined as 2) is connected to a second(?) LED on the NodeMCU next to the antenna, using reverse logic. LOW turns the LED on.

[d-a-v]

https://github.com/nodemcu/nodemcu-devkit
there is a led on gpio16

[DaleSchultz]

LED_BUILTIN is defined as 16 and does not activate an LED, neither HIGH nor LOW

This is what people keep reporting.

GPIO16 does NOT activate an on board LED on Multiple NodeMCU boards that I bought recently. I don't know how to tell what version they are but they use the CH340 drivers and have "HW-625" silkscreened near the antenna. The chip is marked ESP8266MOD.

[d-a-v]

Can you propose a pull request to change led definition to 2 ?

[DaleSchultz]

I am not sure how to do that, nor do I feel confident about submitting a change. I was confirming what has been reported and seemingly dismissed.

[tablatronix]

The official nodemcu boards have a led on gpio 16, maybe you are using some lolin verison or something. Nodemcu official boards use cp2102, I am not sure if these clone boards have a board definition or not.

[dsyleixa]

I can confirm that LED_BUILTIN for ESP-12E nodeMCU is GPIO 16 == D0:
(board manager nodeMCU 1.0, ver 2.4.0 + 2.5.2)

  Blink

  Turns an LED on for one second, then off for one second, repeatedly.

  Most Arduinos have an on-board LED you can control. On the UNO, MEGA and ZERO
  it is attached to digital pin 13, on MKR1000 on pin 6. LED_BUILTIN is set to
  the correct LED pin independent of which board is used.
  If you want to know what pin the on-board LED is connected to on your Arduino
  model, check the Technical Specs of your board at:
  https://www.arduino.cc/en/Main/Products

  modified 8 May 2014
  by Scott Fitzgerald
  modified 2 Sep 2016
  by Arturo Guadalupi
  modified 8 Sep 2016
  by Colby Newman

  This example code is in the public domain.

  http://www.arduino.cc/en/Tutorial/Blink
*/

// the setup function runs once when you press reset or power the board
void setup() {
  Serial.begin(115200);
  delay(2000);
  // initialize digital pin LED_BUILTIN as an output.
  pinMode(LED_BUILTIN, OUTPUT);
  Serial.println();
  Serial.print("LED_BUILTIN=");Serial.print(LED_BUILTIN);
  Serial.println();
}

// the loop function runs over and over again forever
void loop() {
  digitalWrite(LED_BUILTIN, HIGH);   // turn the LED on (HIGH is the voltage level)
  Serial.print(LED_BUILTIN); Serial.print("="); Serial.println("HIGH");
  delay(1000);                       // wait for a second
  digitalWrite(LED_BUILTIN, LOW);    // turn the LED off by making the voltage LOW
  Serial.print(LED_BUILTIN); Serial.print("="); Serial.println("LOW");
  delay(1000);                       // wait for a second
}

output:

LED_BUILTIN=16

16=HIGH
16=LOW
16=HIGH
16=LOW
16=HIGH
16=LOW
16=HIGH
16=LOW
16=HIGH
16=LOW
16=HIGH
16=LOW
16=HIGH

[dsyleixa]

I have to disagree:
as stated, the built-in LED for ESP-12E nodeMCU is GPIO 16 == D0, and this is true for all of my 6 ESP-12E Boards!
By GPIO 2 nothing happens, neither LED is flashing.
Board-driver: nodeMCU 1.0

[devyte]

There are boards with a led on 2, boards with a led on 16, and boards with both, all called nodemcu. I'm defining the builtin as 2 to match other boards based on the esp12 that have the led. If your board has a led on 16, please use the aux.

[tablatronix]

That should work , although there is only one real official nodemcu.

[mhightower83]

An observation of what I think I am reading here and what I have seen, there appears to be an ESP-12E development board containing an ESP-12E module. The ESP-12E module (and its various clones) sometimes have an LED on GPIO-2. The LED would appear to be optional at least on some of the cloned modules. The schematic reference above of a development board has an LED on GPIO-16. Last, and frustratingly the schematic in the datasheet for the ESP-12E module fails to show there is an LED on the module; however, a reversed engineered schematic shows it on GPIO-2.

[d-a-v]

There are two possibilities:

• two board entries for nodeMCU-v1.0, one for gpio2 and the other for gpio16
• a single entry for nodeMCU-v1.0, but a led menu like with generic board

[dsyleixa]

IMO there already far too many entries in the boards menu for either esp8266 type, so I would be fine with option b)

[devyte]

@dyslexia there is a filtering capability now to only show boards you're interested in.

[dsyleixa]

@devyte
thanks, neither heard of it - nor found after having searched for it

[mhightower83]

@dsyleixa, devyte is referring to this How to create an abridged boards.txt file it is in the FAQ.

Also for the non-ESP8266 boards.txt files, that are too long, you can manually edit those down to the boards you use. Note, you cannot delete all of them. There must be at least one board in a boards.txt file. Don't forget to make a backup copy.

[dsyleixa]

@mhightower83
thank you, nice to see that but too cumbersome and too confusing for common Arduino users

[mhightower83]

@dsyleixa ?? only the 1st two commands are needed for what you want. You can do copy-paste and edit the favorites file. The rest are additional things that can be done. Or are you referring to the lake of a GUI interface?

[dsyleixa]

well, this is not the topic here, but I doubt that me or other common Arduino users would ever do that.
So the less boards in the IDE boards menu, the better.