Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a full debug build of some number of tests to CI #5143

Closed
earlephilhower opened this issue Sep 17, 2018 · 0 comments
Closed

Add a full debug build of some number of tests to CI #5143

earlephilhower opened this issue Sep 17, 2018 · 0 comments
Assignees
@earlephilhower
Labels
component: tools type: enhancement
Milestone
2.5.0

Comments

@earlephilhower
Copy link
Collaborator

The debug macros sometimes cause trouble when the main code is changed, since they are NOPs until debugging is enabled.

To ensure changes don't break debug builds, we should add a build of some representative tests with full debugging enabled to the CI.

Probably don't need to build all with full debug, but one or two examples from each major subsystem.
@earlephilhower earlephilhower self-assigned this Sep 17, 2018
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Sep 18, 2018
@earlephilhower
Add full debug builds for all tests
aaccfc4 
In order to ensure the -DEBUG builds don't fail with checked-in code, add
two jobs which build even/odd with full debug flags to Travis.

Fixes esp8266#5143
@earlephilhower earlephilhower mentioned this issue Sep 18, 2018
Merged
@devyte devyte added this to the 2.5.0 milestone Sep 21, 2018
devyte pushed a commit that referenced this issue Sep 21, 2018
@earlephilhower @devyte
Add full debug builds for all tests (#5146)
0a04ebf 
* Add full debug builds for all tests

In order to ensure the -DEBUG builds don't fail with checked-in code, add
two jobs which build even/odd with full debug flags to Travis.

Fixes #5143

* Add in dump of platform.txt to verify build options

* Fix BASH comparison of strings

* Fix debug-mode compile error in ESP8266AVRISP

* Add -Wextra to CI (matches IDE "All" warnings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@earlephilhower earlephilhower

Labels
component: tools type: enhancement
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@earlephilhower @devyte