Skip to content

There is no such word as "authentification" #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jayeye opened this issue Sep 30, 2018 · 4 comments
Closed

There is no such word as "authentification" #5187

jayeye opened this issue Sep 30, 2018 · 4 comments

Comments

@jayeye
Copy link

jayeye commented Sep 30, 2018

The correct word is "authentication".

@d-a-v
Copy link
Collaborator

d-a-v commented Sep 30, 2018

where is it ?

@dragondaud
Copy link
Contributor

@jayeye It really helps to include some details when opening an issue, however a quick grep finds:

./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino:bool is_authentified() {
./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino:  Serial.println("Enter is_authentified");
./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino://root page can be accessed only if authentification is ok
./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino:  if (!is_authentified()) {
./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino://no need authentification
./libraries/ESP8266WebServer/examples/SimpleAuthentification/SimpleAuthentification.ino:    server.send(200, "text/plain", "this works without need of authentification");

The name of the example, and its directory, and several uses in code should be fixed, as well as well as 'is_authentified' should be 'is_authenticated'. Surprised this wasn't noticed earlier.

@5chufti
Copy link
Contributor

5chufti commented Sep 30, 2018

The correct word is "authentication".

Says who?
https://en.oxforddictionaries.com/definition/authentification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants