Skip to content

Finalize callback list implementation, and migrate wifi events to use it. #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks done
devyte opened this issue Feb 19, 2019 · 5 comments
Open
6 tasks done

Comments

@devyte
Copy link
Collaborator

devyte commented Feb 19, 2019

Basic Infos

  • This issue complies with the issue POLICY doc.
  • I have read the documentation at readthedocs and the issue is not addressed there.
  • I have tested that the issue is present in current master branch (aka latest git).
  • I have searched the issue tracker for a similar issue.
  • If there is a stack dump, I have decoded it.
  • I have filled out all fields below.

Platform

  • Hardware: all
  • Core Version: 2.5.0
  • Development Env: all
  • Operating System: all

Settings in IDE

  • Module: all

Problem Description

After some discussion, @hreintke pulled out the wifi callback event list implementation into a proposed standalone implementation. That implementation needs to be tested, covered by tests, examples, and the wifi event system needs to be migrated to use it. Once that is done, other callback systems could potentially make use of it.

Ref: #5710

@hreintke
Copy link
Contributor

@devyte : I can work on this.

What is your idea on the way forward for this.
I would propose to first focus on functionality and later on the implementation details (list/vector/move).

There is a simple example included in the initial PR. I'll do some first tests on memory usage/leaks.
What other tests and examples are you thinking of ?

When these work OK, I'll make a start with wifi event migration.

@devyte
Copy link
Collaborator Author

devyte commented Feb 20, 2019

@hreintke much appreciated!
What I had in mind was along the lines of:

  1. Make sure functionality needed by the wifi event system isn't missing
  2. Check api (parameter passing, const refs, typedefs, container use, usability in general
  3. Look for other use cases in the core and in our libraries, and check whether additional functionality is needed in any such use cases found
  4. Implement simple usage examples based on the use case found in the previous point

@hreintke
Copy link
Contributor

@devyte : OK.

Please let me know of possible usecases you know in core/libraries. it's not easy to search for those
What is the expected timeline for 2.6.0. ?

@devyte
Copy link
Collaborator Author

devyte commented Nov 5, 2019

Merged the callbacklist as experimental, now pending migration of the WiFi callbacks to use it. Pushing back for that second part.

@devyte devyte modified the milestones: 2.6.0, 2.7.0 Nov 5, 2019
@devyte devyte modified the milestones: 2.7.0, 2.7.1 Apr 23, 2020
@devyte devyte modified the milestones: 2.7.1, 2.7.2 May 11, 2020
@devyte
Copy link
Collaborator Author

devyte commented Jul 6, 2020

This is a nice-to-have, so pushing back again pending some time window that allows implementing the code unification.

@devyte devyte modified the milestones: 2.7.2, 3.0.0 Jul 6, 2020
@d-a-v d-a-v modified the milestones: 3.0.0, 3.0.1 Mar 31, 2021
@d-a-v d-a-v modified the milestones: 3.0.1, 3.1 Jun 16, 2021
@d-a-v d-a-v modified the milestones: 3.1, 4.0.0 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants