Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espsoftwareserial 6.4.0 included in arduino core 2.6.3 is faulty #6920

Closed
5 of 6 tasks
dirkmueller opened this issue Dec 18, 2019 · 9 comments
Closed
5 of 6 tasks

espsoftwareserial 6.4.0 included in arduino core 2.6.3 is faulty #6920

dirkmueller opened this issue Dec 18, 2019 · 9 comments

Comments

@dirkmueller
Copy link
Contributor

dirkmueller commented Dec 18, 2019

Basic Info

  • This issue complies with the issue POLICY doc.
  • I have read the documentation at readthedocs and the issue is not addressed there.
  • I have tested that the issue is present in current master branch (aka latest git).
  • I have searched the issue tracker for a similar issue.
  • If there is a stack dump, I have decoded it.
  • I have filled out all fields below.

Problem Description

The espsoftwareserial release included in the 2.6.3 release is not working for readBytes() anymore, see
plerup/espsoftwareserial#128

for details. This is a tracker issue in the hope that a 2.6.4 release can be cut when the issue is fixed.

@dirkmueller
Copy link
Contributor Author

Upcoming EspSoftwarSerial 6.5.0 release will fix this issue: plerup/espsoftwareserial@80c3127

@dirkmueller
Copy link
Contributor Author

@dirkmueller
Copy link
Contributor Author

@d-a-v could you please help with a 2.6.4 release?

@dok-net
Copy link
Contributor

dok-net commented Dec 19, 2019

WIP again. Don't merge until further notice, please.

@dirkmueller
Copy link
Contributor Author

WIP again. Don't merge until further notice, please.

This has been fixed by merging 6.5.3. please move ahead with a new release

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 21, 2019

Next release will be 2.7.0.
If you need a board installer I updated the alpha-release including the change

@dirkmueller
Copy link
Contributor Author

@d-a-v I understand that this is the plan, I was asking whether we can turn around a quick 2.6.x new releaese as there haven't been any major changes in master git since the last release yet.

@dok-net
Copy link
Contributor

dok-net commented Dec 21, 2019

@dirkmueller @d-a-v For any plans to fulfill this wish, I'd also like to mention that I've made an otherwise relevant, but not for EspSoftwareSerial, fix to the included Delegate.h - it's in the Non-ESP Arduino code. In order to not have different versions of Delegate.h in released CoopTask (via Arduino library manager) and EspSoftwareSerial (submoduled on ESP8266 only), perhaps you could give me the benefit of the doubt and merge EspSoftwareSerial 6.5.4 (#6932) instead.

@devyte
Copy link
Collaborator

devyte commented Dec 26, 2019

Like @d-a-v said, next release is 2.7.0. When this was opened we were already passed the point of no return for it.
The referenced PRs are merged. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants