Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: simplify PolledTimeout namespace #7903

Closed
d-a-v opened this issue Mar 2, 2021 · 1 comment · May be fixed by #7960
Closed

Feature Request: simplify PolledTimeout namespace #7903

d-a-v opened this issue Mar 2, 2021 · 1 comment · May be fixed by #7960

Comments

@d-a-v
Copy link
Collaborator

d-a-v commented Mar 2, 2021

PolledTimeout's namespace is large.

example: esp8266::polledTimeout::periodicFastMs ledBlink(1000);
It is, among other use-cases, aimed at replacing timed events calling millis() and is thus used at several places in the core and examples.
It is also the preferred solution proposed to users when they're facing delay issues in their main loop ("do not use delay(), prefer PolledTimeout, check the example").

There is at least an aborted proposal to make it simpler with a mention to specific ideas for addressing this issue.

Kindly requesting to:

  • remove the necessity of including <something.h> to use it (like with millis() and delay() which require nothing)
  • reduce the namespace size, or remove it
@d-a-v d-a-v added this to the 3.0.0 milestone Mar 2, 2021
@d-a-v d-a-v linked a pull request Apr 5, 2021 that will close this issue
@d-a-v d-a-v modified the milestones: 3.0.0, 3.0.1 May 16, 2021
@d-a-v d-a-v modified the milestones: 3.0.1, 3.1 Jun 16, 2021
@d-a-v d-a-v added the wontfix label Jun 13, 2022
@d-a-v
Copy link
Collaborator Author

d-a-v commented Jun 13, 2022

closing as wontfix.

@d-a-v d-a-v closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants