Skip to content

Conversation

sticilface
Copy link
Contributor

as mentioned #1088

@sticilface sticilface changed the title Proposed fix for long filenames in SPIFFS Proposed filename length check for SPIFFS Nov 27, 2015
@igrr
Copy link
Member

igrr commented Nov 27, 2015

  • I think this check should be done not it FS abstraction layer, but in SPIFFSImpl. Reason is, we may have another FS implementation (like SD) which doesn't share this limitation.
  • This check should also be done in all other functions which take file names. Perhaps it's worth adding a function like bool SPIFFSImpl::_isValidFilename(const char*) which would be called from other places.

@sticilface
Copy link
Contributor Author

This sounds very reasonable

@sticilface
Copy link
Contributor Author

Looking at https://github.com/esp8266/Arduino/blob/master/cores/esp8266/spiffs_api.cpp#L49 it might be better for you to implement it. I don't understand the code that well!

igrr added a commit that referenced this pull request Dec 10, 2015
@igrr igrr closed this Dec 10, 2015
@sticilface sticilface deleted the patch-2 branch December 10, 2015 22:35
Normola pushed a commit to Normola/Arduino that referenced this pull request Feb 19, 2020
Added button:active(clicked) "animation"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants