Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for RTC user memory in ESP-specific APIs. #1836

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

MacroYau
Copy link
Contributor

No description provided.

@igrr
Copy link
Member

igrr commented Apr 4, 2016

Hi, thanks for the pull request.
It would be really cool if we could remove the limitation of system_rtc_mem_read/write that pointers have to be 4-byte aligned. We are doing something similar in SPIFFS HAL, where we split reads and writes to make sure they are aligned: https://github.com/esp8266/Arduino/blob/master/cores/esp8266/spiffs_hal.cpp#L31-L88.
That, and also would be great to add offset parameter so that users could write something not only at the beginning of RTC memory, but at some offset as well.

@ghost
Copy link

ghost commented Apr 11, 2016

Can one of the admins verify this patch?

@igrr igrr merged commit 2a4081b into esp8266:master Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants