Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2026.
This commit changes the API for subscribing to WiFi events.
Currently there are two functions:
WiFi.onEvent
andWiFi.removeEvent
. The first one allows one to listen to WiFi events but doesn't pass along any useful information about the event. Then other one has a bug and doesn't work in some cases.Proposed changes are as follows:
WiFi.onEvent
is kept but marked deprecated. It should not be used in new code.WiFi.removeEvent
is removed.A bunch of new functions are added:
These functions take a function object or a function pointer, and return a
WiFiEventHandler
instance.WiFiEventHandler
is an opaque type which represents an active subscription to WiFi events. It helps manage un-subscription from WiFi events by binding it to object lifetime.Consider the following example
If a
FooServer
instance goes out of scope or is deleted,mConnectHandler
andmDisconnectHandler
will be deleted as well, automatically cancelling subscription to GotIP and Disconnected events.