MD5Builder::addStream: fixed falsy calculated hash for len > filelength #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would you mind adding your test case into host tests folder as well? |
Current coverage is 26.30%@@ master #2126 diff @@
==========================================
Files 19 19
Lines 3634 3634
Methods 328 328
Messages 0 0
Branches 585 585
==========================================
Hits 956 956
Misses 2513 2513
Partials 165 165
|
|
oh.. of course! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue with the MD5Builder::addStream method.
If len > filelength handled a false hash was calculated. Refactored for better readability.
Tested with a filestream resulted in calculating the correct hash.