Add support to Print::printf for printing from flash #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
April 20, 2016 12:57
|
@igrr is travis borked? |
As discussed, such functionality should not be expected from printf
Current coverage is 27.64%
|
| @@ -63,6 +63,53 @@ size_t Print::printf(const char *format, ...) { | |||
| return len; | |||
| } | |||
|
|
|||
| size_t Print::printf(const __FlashStringHelper * format, ...) { | |||
There was a problem hiding this comment.
How about introducing Print:vprintf(PGM_P format, va_list argp) and make the other 2 use it?
size_t Print::printf(const __FlashStringHelper * format, ...) {
va_list arg;
va_start(arg, format);
PGM_P fmt = reinterpret_cast<PGM_P>(format);
size_t len = vprintf(fmt, arg);
va_end(arg);
return len;There was a problem hiding this comment.
removed that printf all together. Check the latest commit
|
@me-no-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.