Use the same DEBUG provisions as ESP8266WebServer #2279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since DEBUG is a generic flag used by other projects, and since DEBUG_OUTPUT was not defined in this case, I opted to set DEBUG_OUTPUT as part of this file (cfr. ESP8266WebServer) and changed the default DEBUG #ifdef to a more specific DEBUG_ESP_DNS_SERVER #ifdef, also cfr. ESP8266WebServer.
This ensure out project using WiFiManager does not fail to build with the error:
```
/home/dag/home-made/ADEM/arduino15/packages/esp8266/hardware/esp8266/2.3.0/libraries/DNSServer/src/DNSServer.cpp: In member function 'void DNSServer::replyWithIP()':
/home/dag/home-made/ADEM/arduino15/packages/esp8266/hardware/esp8266/2.3.0/libraries/DNSServer/src/DNSServer.cpp:148:5: error: 'DEBUG_OUTPUT' was not declared in this scope
DEBUG_OUTPUT.print("DNS responds: ");
^
```
Current coverage is 27.76%@@ master #2279 diff @@
==========================================
Files 20 20
Lines 3641 3641
Methods 334 334
Messages 0 0
Branches 675 675
==========================================
Hits 1011 1011
Misses 2452 2452
Partials 178 178
|
|
Closing in favor of #5329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DEBUG is a generic flag used by other projects, and since DEBUG_OUTPUT was not defined in this case, I opted to set DEBUG_OUTPUT as part of this file (cfr. ESP8266WebServer) and changed the default DEBUG #ifdef to a more specific DEBUG_ESP_DNS_SERVER #ifdef, also cfr. ESP8266WebServer.
This ensure out project using WiFiManager does not fail to build with the error: