Fixed libb64 decoder. #2883
Merged
Fixed libb64 decoder. #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libb64 decoder works when "char" type is signed. In esp8266 xtensa gcc "char" is unsigned, so libb64 decoder does not work. In the implementation file I replaced "char" to "int8_t" and created function wrappers in order to keep existing interface.
Current coverage is 27.80% (diff: 100%)@@ master #2883 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
igrr
requested changes
Jan 19, 2017
|
|
||
| int base64_decode_value(char value_in) | ||
| { | ||
| return base64_decode_value_signed(*((int8_t *) &value_in)); |
There was a problem hiding this comment.
the rest of the file doesn't seem to use tabs for indentation
There was a problem hiding this comment.
Oops, sorry for this.
me-no-dev
added a commit
to espressif/arduino-esp32
that referenced
this pull request
May 6, 2017
Implements: esp8266/Arduino#2883 Fixes: #313 Fixes: #344
blue-2357
pushed a commit
to blue-2357/arduino-esp32
that referenced
this pull request
Jul 17, 2024
Implements: esp8266/Arduino#2883 Fixes: espressif/arduino-esp32#313 Fixes: espressif/arduino-esp32#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libb64 decoder works when "char" type is signed. In esp8266 xtensa gcc "char" is unsigned, so libb64 decoder does not work. In the implementation file I replaced "char" to "int8_t" and created function wrappers in order to keep existing interface.
I tested it, it works!