Documenting a few Esp.cpp methods #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding: getCoreVersion, getSdkVersion, getCpuFreqMHz, getSketchSize, getFreeSketchSpace and getSketchMD5.
igrr
requested changes
May 8, 2017
doc/libraries.md
Outdated
|
|
||
| `ESP.getSketchSize()` returns the size of the current sketch as an unsigned 32-bit integer. | ||
|
|
||
| `ESP.getFreeSketchSpace()` returns the free sketch space as an unsigned 8-bit intege. |
There was a problem hiding this comment.
Typo, "intege". Also the function returns an uint32_t, not an uint8_t.
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
+ Coverage 27.57% 27.82% +0.24%
==========================================
Files 20 20
Lines 3655 3626 -29
Branches 678 656 -22
==========================================
+ Hits 1008 1009 +1
+ Misses 2469 2441 -28
+ Partials 178 176 -2
Continue to review full report at Codecov.
|
|
Done. Not sure if I need to rebase tho. |
igrr
approved these changes
May 14, 2017
igrr
added a commit
that referenced
this pull request
May 14, 2017
- 9fd270f Documenting a few Esp.cpp methods (#3057) - 2881e91 Fix typo in client-class.md (#3045) - 97373e7 Add instructions how to re-enable DHCP (#2600) - af0f5ed Issue #1062: Implement support for HSPI overlap mode. - ca3a172 Addition of gen4-IoD Range boards (#3202) - d2b370b add AsyncPing library to libraries.md (#2889) - adeed6b Updated arduino-esp8266fs-plugin link to 0.3.0 (#2846) - b701b98 Update libraries.md (#2808) - 898d280 Update readme.md (#2809) - remove newlines from ota_updates/readme.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding: getCoreVersion, getSdkVersion, getCpuFreqMHz, getSketchSize, getFreeSketchSpace and getSketchMD5.