Arduino boards with ESP8266 #3121

sergiotomasello · 2017-04-06T13:57:55Z

This PR introduces a new board called Arduino with three models:

Star OTTO
Primo
UNO WiFi

codecov-io · 2017-04-06T14:24:49Z

Codecov Report

Merging #3121 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3121      +/-   ##
=========================================
- Coverage   27.82%   27.6%   -0.23%     
=========================================
  Files          20      20              
  Lines        3626    3655      +29     
  Branches      656     678      +22     
=========================================
  Hits         1009    1009              
- Misses       2441    2468      +27     
- Partials      176     178       +2

Impacted Files	Coverage Δ
cores/esp8266/spiffs_api.h	`44.37% <0%> (-0.33%)`	⬇️
cores/esp8266/spiffs/spiffs_nucleus.c	`41.78% <0%> (-0.31%)`	⬇️
cores/esp8266/spiffs/spiffs_hydrogen.c	`38.06% <0%> (-0.28%)`	⬇️
cores/esp8266/spiffs/spiffs_gc.c	`2.57% <0%> (-0.05%)`	⬇️
cores/esp8266/WString.cpp	`15.13% <0%> (-0.04%)`	⬇️
cores/esp8266/Print.cpp	`5.03% <0%> (-0.04%)`	⬇️
cores/esp8266/core_esp8266_noniso.c	`0% <0%> (ø)`	⬆️
cores/esp8266/spiffs/spiffs_check.c	`0% <0%> (ø)`	⬆️
cores/esp8266/Stream.cpp	`17.42% <0%> (+0.23%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01638f...663244e. Read the comment docs.

igrr

Changes look mostly good, just a small suggestion about the way f_crystal is defined.

igrr · 2017-04-06T14:28:33Z

cores/esp8266/core_esp8266_phy.c

@@ -88,7 +88,11 @@ static const uint8_t ICACHE_FLASH_ATTR phy_init_data[128] =
    // 0: 40MHz
    // 1: 26MHz
    // 2: 24MHz
+    #ifdef F_CRYSTAL


Let me suggest an approach which will not require f_crystal value to be added to all the boards... Since 26MHz is pretty much the default for the ESP8266 based designs, we only need to add f_crystal=40000000 to the boards which use 40 MHz crystal.

Then you can have something along these lines:

#if F_CRYSTAL == 40000000 [48] = 0, #else [48] = 1, #endif

👍 I can change it, but my approach allows users to use different f_crystal values even for the esp8266 generic board

Fair enough, let's keep this menu for generic. Other boards can use 26MHz via silent default.

eheh, I just pushed a new commit without menu... let me know if you want me to put it back inside :)

i'm going to push a new (squashed) commit

igrr · 2017-04-06T14:29:06Z

boards.txt

@@ -1397,6 +1430,7 @@ espino.serial.disableRTS=true

 espino.build.mcu=esp8266
 espino.build.f_cpu=80000000L
+espino.build.f_crystal=1


suggest making f_crystal value similar to f_cpu, by expressing it in Hz.

igrr · 2017-04-06T14:30:15Z

boards.txt

+arduino-esp8266.name=Arduino
+
+arduino-esp8266.upload.tool=esptool
+arduino-esp8266.upload.speed=9600


Is the default upload speed intentionally set that low?

yes, because into uno wifi dev. ed. the maximum speed between ATmega328P and esp8266 is 9600, for the other boards the speed can be higher.

sergiotomasello · 2017-04-10T16:48:51Z

@igrr when you believe that it can be merged and when you believe that version 2.4.0 will be released for the Arduino IDE Board Manager?

igrr · 2017-04-10T16:56:51Z

Seems like the build has failed, please check the syntax:
https://travis-ci.org/esp8266/Arduino/builds/220486369#L837

I can merge this as soon as build passes.
W.r.t. releasing 2.4.0, can't promise anything, there is a lot of functionality currently broken in master.

igrr · 2017-04-10T17:00:16Z

boards.txt

 generic.build.board=ESP8266_ESP01
 generic.build.core=esp8266
 generic.build.variant=generic
 generic.build.flash_mode=qio
 generic.build.spiffs_pagesize=256
 generic.build.debug_port=
 generic.build.debug_level=
+generic.build.extra_flags=-DF_CRYSTAL={build.f_crystal}


seems like this expression is not getting expanded.

Arduino IDE expands it before compiling, into console I get the correct value: -DF_CRYSTAL=24000000

Compiling sketch... "/Users/sergio/Library/Arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/1.20.0-26-gb404fb9-2/bin/xtensa-lx106-elf-g++" -D__ets__ -DICACHE_FLASH -U__STRICT_ANSI__ "-I/Users/sergio/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/tools/sdk/include" "-I/Users/sergio/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/tools/sdk/lwip/include" "-I/Users/sergio/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/tools/sdk/libc/xtensa-lx106-elf/include" "-I/var/folders/k4/q1bl6yfs2rv0n006w3nh0rk40000gn/T/arduino_build_308216/core" -c -w -Os -g -mlongcalls -mtext-section-literals -fno-exceptions -fno-rtti -falign-functions=4 -std=c++11 -MMD -ffunction-sections -fdata-sections -DF_CPU=80000000L -DLWIP_OPEN_SRC -DARDUINO=10801 -DARDUINO_ESP8266_ESP01 -DARDUINO_ARCH_ESP8266 -DARDUINO_BOARD="ESP8266_ESP01" -DF_CRYSTAL=24000000 "-I/Users/sergio/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/cores/esp8266" "-I/Users/sergio/Library/Arduino15/packages/esp8266/hardware/esp8266/2.3.0/variants/generic" "/var/folders/k4/q1bl6yfs2rv0n006w3nh0rk40000gn/T/arduino_build_308216/sketch/sketch_apr11a.ino.cpp" -o "/var/folders/k4/q1bl6yfs2rv0n006w3nh0rk40000gn/T/arduino_build_308216/sketch/sketch_apr11a.ino.cpp.o"

This kind of expression is needed if you want to keep the Crystal Freq. Menu to allow users to select crystal frequency by themselves.

For the same reason I should also change this:

arduino-esp8266.build.extra_flags=-DF_CRYSTAL={build.f_crystal}

Let me know how to proceed and move forward ;)

I suppose that Travis build is failing because I'm using an older Arduino IDE version there?

Anyway, I'm even okay with having f_crystal=26000000 specified for every board. Hope this can fix the build issue.

probably... which version are you using?

If you are agree I proceed in this way:

change #if statement in core_esp8266_phy.c as you suggest the first time

#if F_CRYSTAL == 40000000 [48] = 0, #else [48] = 1, #endif

remove Crystal Freq. menu from boards.txt

update arduino-esp8266 entries to prevent Travis build failure

Hmm, actually I'm using nightly:
https://github.com/esp8266/Arduino/blob/master/.travis.yml#L23

Agree with your suggestion, please go ahead.

done! build success 👍

andrea-83 and others added 3 commits March 23, 2017 18:24

upd: added support for arduino board with ESP8266

99d510b

fix: added crystal oscillator frequency setting

18dd42f

add: support for arduino boards with esp8266 chip

4f9bba7

igrr requested changes Apr 6, 2017

View reviewed changes

sergiotomasello force-pushed the arduino-boards-esp8266 branch from 1fcf73c to 10b218e Compare April 10, 2017 09:22

igrr reviewed Apr 10, 2017

View reviewed changes

upd: default crystal freq 26M for all boards, 40M for arduino

663244e

sergiotomasello force-pushed the arduino-boards-esp8266 branch from 10b218e to 663244e Compare April 11, 2017 14:33

igrr merged commit a922426 into esp8266:master Apr 11, 2017

jeremypoulter mentioned this pull request Apr 12, 2017

Added support for 40MHz crystal frequency #3025

Closed

jwrw mentioned this pull request May 24, 2017

Add Crystal Frequency menu item for Generic module #3288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arduino boards with ESP8266 #3121

Arduino boards with ESP8266 #3121

sergiotomasello commented Apr 6, 2017 •

edited

Loading

codecov-io commented Apr 6, 2017 •

edited

Loading

igrr left a comment

igrr Apr 6, 2017 •

edited

Loading

sergiotomasello Apr 10, 2017

igrr Apr 10, 2017

sergiotomasello Apr 10, 2017

sergiotomasello Apr 10, 2017

igrr Apr 6, 2017

sergiotomasello Apr 10, 2017

igrr Apr 6, 2017

sergiotomasello Apr 10, 2017

sergiotomasello commented Apr 10, 2017

igrr commented Apr 10, 2017

igrr Apr 10, 2017

sergiotomasello Apr 11, 2017

igrr Apr 11, 2017

sergiotomasello Apr 11, 2017 •

edited

Loading

igrr Apr 11, 2017

sergiotomasello Apr 11, 2017

Arduino boards with ESP8266 #3121

Arduino boards with ESP8266 #3121

Conversation

sergiotomasello commented Apr 6, 2017 • edited Loading

codecov-io commented Apr 6, 2017 • edited Loading

Codecov Report

igrr left a comment

Choose a reason for hiding this comment

igrr Apr 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiotomasello commented Apr 10, 2017

igrr commented Apr 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiotomasello Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiotomasello commented Apr 6, 2017 •

edited

Loading

codecov-io commented Apr 6, 2017 •

edited

Loading

igrr Apr 6, 2017 •

edited

Loading

sergiotomasello Apr 11, 2017 •

edited

Loading