Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64::encode() adds newlines every 72 (encoded) chars output. #3208

Merged
merged 3 commits into from
May 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cores/esp8266/base64.cpp
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,20 @@ extern "C" {
* @param length size_t
* @return String
*/
String base64::encode(uint8_t * data, size_t length) {
String base64::encode(uint8_t * data, size_t length, bool doNewLines) {
// base64 needs more size then the source data
size_t size = ((length * 1.6f) + 1);
char * buffer = (char *) malloc(size);
if(buffer) {
base64_encodestate _state;
base64_init_encodestate(&_state);
if(doNewLines)
{
base64_init_encodestate(&_state);
}
else
{
base64_init_encodestate_nonewlines(&_state);
}
int len = base64_encode_block((const char *) &data[0], length, &buffer[0], &_state);
len = base64_encode_blockend((buffer + len), &_state);

Expand All @@ -57,7 +64,7 @@ String base64::encode(uint8_t * data, size_t length) {
* @param text String
* @return String
*/
String base64::encode(String text) {
return base64::encode((uint8_t *) text.c_str(), text.length());
String base64::encode(String text, bool doNewLines) {
return base64::encode((uint8_t *) text.c_str(), text.length(), doNewLines);
}

7 changes: 5 additions & 2 deletions cores/esp8266/base64.h
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@

class base64 {
public:
static String encode(uint8_t * data, size_t length);
static String encode(String text);
// NOTE: The default behaviour of backend (lib64)
// is to add a newline every 72 (encoded) characters output.
// This may 'break' longer uris and json variables
static String encode(uint8_t * data, size_t length, bool doNewLines = true);
static String encode(String text, bool doNewLines = true);
private:
};

Expand Down
9 changes: 8 additions & 1 deletion cores/esp8266/libb64/cencode.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ void base64_init_encodestate(base64_encodestate* state_in){
state_in->step = step_A;
state_in->result = 0;
state_in->stepcount = 0;
state_in->stepsnewline = CHARS_PER_LINE;
}


void base64_init_encodestate_nonewlines(base64_encodestate* state_in){
base64_init_encodestate(state_in);
state_in->stepsnewline = -1;
}

char base64_encode_value(char value_in){
Expand Down Expand Up @@ -65,7 +72,7 @@ int base64_encode_block(const char* plaintext_in, int length_in, char* code_out,
*codechar++ = base64_encode_value(result);

++(state_in->stepcount);
if (state_in->stepcount == CHARS_PER_LINE/4){
if ((state_in->stepcount == CHARS_PER_LINE/4) && (state_in->stepsnewline > 0)){
*codechar++ = '\n';
state_in->stepcount = 0;
}
Expand Down
2 changes: 2 additions & 0 deletions cores/esp8266/libb64/cencode.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ typedef struct {
base64_encodestep step;
char result;
int stepcount;
int stepsnewline;
} base64_encodestate;

void base64_init_encodestate(base64_encodestate* state_in);
void base64_init_encodestate_nonewlines(base64_encodestate* state_in);

char base64_encode_value(char value_in);

Expand Down