Move UMM debug messages into PMEM #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
reviewed
Aug 1, 2017
| @@ -550,44 +551,45 @@ | |||
| #undef DBG_LOG_FORCE | |||
|
|
|||
| /* ------------------------------------------------------------------------- */ | |||
| #define printf_P(fmt, ...) do { static const char fstr[] PROGMEM = fmt; char rstr[sizeof(fmt)]; for (size_t i=0; i<sizeof(rstr); i++) rstr[i] = fstr[i]; printf(rstr, ##__VA_ARGS__); } while (0) | |||
There was a problem hiding this comment.
Since we're doing this, can we also #define printf(...) printf_P(__VA_ARGS__)? It will make it much easier to upgrade umm to upstream version, if we ever want to do that.
There was a problem hiding this comment.
Thanks for the collaborator status. I'm happy to help out.
I'll refactor the patch this weekend and put in a new one with printf() macro'd instead of the changes inline.
|
(p.s. Thank you for all the contributions — I have also added you as collaborator to the repository!) |
UMM debugging strings are normally placed in RODATA, which uses up scarse memory. Move them to PROGMEM and use macros to replace printf with a version that can handle ROM strings.
earlephilhower
force-pushed
the
ummdebugtopmem
branch
from
0020f84
to
8ca3c3c
Compare
|
Here's the new, 2-liner. |
d-a-v
pushed a commit
to d-a-v/Arduino
that referenced
this pull request
Sep 29, 2017
UMM debugging strings are normally placed in RODATA, which uses up scarse memory. Move them to PROGMEM and use macros to replace printf with a version that can handle ROM strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the UMM debug format strings in PMEM instead of RODATA. Frees around 300 bytes of RAM with debugging disabled, much more when debugging is enabled.