Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: mask GPIO interrupts while attaching/detaching ISR handler #3598

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

igrr
Copy link
Member

@igrr igrr commented Sep 12, 2017

Fixes #2916.

@igrr igrr mentioned this pull request Sep 12, 2017
@igrr
Copy link
Member Author

igrr commented Sep 12, 2017

@ivankravets it looks like pip install -U https://github.com/platformio/platformio/archive/develop.zip fails in Travis CI, could you please take a look?

https://travis-ci.org/esp8266/Arduino/builds/274115561
https://travis-ci.org/esp8266/Arduino/builds/274563672
https://travis-ci.org/esp8266/Arduino/builds/274563832

@ivankravets
Copy link
Collaborator

@igrr I don't know how did it work before 😱

Please merge this PR: #3599

@igrr
Copy link
Member Author

igrr commented Sep 12, 2017

@ivankravets thanks, I see the same line in arduino-esp32 travis-ci script, should it be updated there as well?

@ivankravets
Copy link
Collaborator

@igrr arduino-esp32 is OK because it uses language: python. So, Travis.CI will create Python virtual environment automatically before a build start. In case with language: bash, pip install will install packages to system "storage" where we need sudo permissions.

@igrr igrr merged commit e68e340 into master Sep 13, 2017
@aluis-rcastro
Copy link

Just giving my feedback on that: I have installed the last release with the above fix and now the system is not being reset anymore. Seems like this solved the problem. Thanks...

@igrr igrr deleted the bugfix/gpio_attachinterrupt_race branch January 2, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants