Bugfix/persistentchecks #3798
Merged
Bugfix/persistentchecks #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes assumtions that persistent matches current configs, and prevents changes when such conditions exist
This was referenced Nov 5, 2017
|
@tablatronix will you be making the requested minor changes? |
|
Requested minor changes? |
devyte
requested changes
Feb 27, 2018
| wifi_softap_get_config(&conf_current); | ||
| if(!softap_config_equal(conf, conf_current)) { | ||
| struct softap_config conf_compare; | ||
| if(WiFi._persistent) wifi_softap_get_config_default(&conf_compare); |
| if(sta_config_equal(current_conf, conf)) { | ||
| struct station_config conf_compare; | ||
| if(WiFi._persistent) wifi_station_get_config_default(&conf_compare); | ||
| else wifi_station_get_config(&conf_compare); |
There was a problem hiding this comment.
Do you mean add brackets, or is it using tabs ?
|
Those :p just fix indentation, please. I'd like to have this ready to merge. |
|
woah that just showed up now, weird. |
devyte
approved these changes
Feb 27, 2018
|
Thanks! |
bryceschober
pushed a commit
to bryceschober/Arduino
that referenced
this pull request
Apr 5, 2018
* persistent check fixes fixes assumtions that persistent matches current configs, and prevents changes when such conditions exist * oops * fix code compliance block scoping (cherry picked from commit 0643d6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial test #3641