Skip to content

ESP8266HTTPClient: optionally skip validation when using https #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ESP8266HTTPClient: optionally skip validation when using https #3933

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e29ccb7
if fingerprint is specified as '*' then skip validation.
liebman Dec 7, 2017
38c41b3
Merge branch 'master' into https_fingerprint_wildcard
liebman Dec 8, 2017
bde68d2
Merge branch 'master' into https_fingerprint_wildcard
liebman Dec 9, 2017
bb76098
Merge branch 'master' into https_fingerprint_wildcard
liebman Dec 12, 2017
fb5b8b3
Merge branch 'master' into https_fingerprint_wildcard
liebman Dec 13, 2017
2208547
Merge branch 'master' into https_fingerprint_wildcard
liebman Dec 15, 2017
24d85b1
Merge branch 'master' into https_fingerprint_wildcard
devyte Dec 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ class TLSTraits : public TransportTraits

bool verify(WiFiClient& client, const char* host) override
{
//
// Treat '*' (a.k.a. wildcard) as skip validation, anything is valid
//
if (_fingerprint == "*")
{
return true;
}

auto wcs = static_cast<WiFiClientSecure&>(client);
return wcs.verify(_fingerprint.c_str(), host);
}
Expand Down