Skip to content

Configurable WiFiClientSecure connect timeout, better default value #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2017
Merged

Configurable WiFiClientSecure connect timeout, better default value #4027

merged 3 commits into from
Dec 26, 2017

Conversation

igrr
Copy link
Member

@igrr igrr commented Dec 26, 2017 •
edited
Loading

  • Use Client::_timeout in WiFiClientSecure::connect instead of a hardcoded value. This can be modified via Client::setTimeout before connecting.
  • Set default _timeout for WiFiClientSecure to 15 seconds.

Ref. #3944

@igrr igrr mentioned this pull request Dec 26, 2017
Closed
@ztittle
Copy link
Contributor

ztittle commented Dec 26, 2017

This change looks good to me. Thanks !

@devyte devyte merged commit fac6490 into master Dec 26, 2017
@igrr igrr deleted the bugfix/wificlientsecure_connect_timeout branch December 26, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

+1 more reviewer

@ztittle ztittle ztittle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igrr @ztittle @devyte