-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case change and and 'none' reset option for Digistump Oak #4143
Conversation
The logo is 'digiStump', but is always written in text form as 'Digistump'. The generator fixed an issue with the release version of 2.4.0 not having a resetMethod for the Digistump Oak, and hence not being able to be uploaded to without modifying the boards.txt file. However, the Oak doesn't support auto-reset via serial - it was primarily designed to be a cloud-programmed board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably should also regenerate boards.txt and add it in the commit.
Changes to Digistump config propogated into boards.txt
Damn github, should've done the changes to the local repo and pushed it from there, instead of editing directly on the github page in the first instance. |
I noticed some minor formatting corrections that I was going to do related to the Oak section of docs/boards.rst (title, fix link to serial adapter heading), but I'm not sure if the |
You are right, |
Minor formatting change to Digistump Oak section and regeneration of the doc/boards.rst
Just mentioning this PR here as the regen of boards.rst, if all is good, should close #4083 as well. |
Just a few final bits! :-O lol |
The logo is 'digiStump', but is always written in text form as 'Digistump'.
The generator fixed an issue with the release version of 2.4.0 not having a resetMethod for the Digistump Oak, and hence not being able to be uploaded to without modifying the boards.txt file. However, the Oak doesn't support auto-reset via serial - it was primarily designed to be a cloud-programmed board. Hence the addition of another resetMacro macro.