Feature: I2S callback on DMA read #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix I2S base frequency
Less is more
|
The next rev is going to be bugfix, with new cool features like this for the follow-on. Thx! |
earlephilhower
requested changes
Mar 9, 2018
cores/esp8266/core_esp8266_i2s.c
Outdated
| ETS_SLC_INTR_ENABLE(); | ||
| } | ||
| } | ||
|
|
||
| void ICACHE_FLASH_ATTR i2s_set_callback(void (*callback) (void)){ |
There was a problem hiding this comment.
Now that 2.4.1 is out this can get into the merge queue. Only minor change I would request is to remove the ICACHE_FLASH_ATTR from the set-callback function. There's no need for this to be kept in precious IRAM.
| @@ -51,6 +51,7 @@ bool i2s_write_lr(int16_t left, int16_t right);//combines both channels and call | |||
| bool i2s_is_full();//returns true if DMA is full and can not take more bytes (overflow) | |||
| bool i2s_is_empty();//returns true if DMA is empty (underflow) | |||
| int16_t i2s_available();// returns the number of samples than can be written before blocking | |||
| void i2s_set_callback(void (*callback) (void)); | |||
There was a problem hiding this comment.
(continuing prior thought)
The actual callback function passed in, though, needs to be in IRAM. A comment in the code to that effect would be appreciated here, so it's obvious to people coming into it that it's an ISR and needs to be very special...
|
The requested changes are implemented, lets hope this gets merged soon :)) |
earlephilhower
approved these changes
Mar 19, 2018
|
Thanks, squashed and committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to fill the DMA buffer on demand using callback function (or at least set a flag in the callback and do stuff later outside of the interrupt routine). This will save a lot of overhead because the only way to do it now is to check in a loop if there's empty buffer waiting to be filled.