Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functional callback to Ticker #4209

Closed
wants to merge 1 commit into from
Closed

Add Functional callback to Ticker #4209

wants to merge 1 commit into from

Conversation

hreintke
Copy link
Contributor

Add Scheduled callback to Ticker
This the rebased version of #4062.

Also adds an example

Add Scheduled callback to Ticker
@devyte devyte modified the milestones: 2.5.0, 2.4.2 Jun 29, 2018
@devyte devyte self-assigned this Jul 4, 2018
@devyte
Copy link
Collaborator

devyte commented Aug 6, 2018

@hreintke this is supposed to supersede #2738 , but the PR looks broken, e.g.: the source repo seems to be gone.
Could you please take a look? If you make a new PR, please close this one.
You probably know this already, but jic it helps, here's how I do PRs:
-fork this repo to have your own
-clone your fork locally
-make a branch in your local git (e.g.: git checkout -b functicker)
-commit everything to that branch
-push to your fork
-make PR from repo webpage (either your fork or this one)
-If changes are requested, commit to your branch locally, then push to your fork (PR updates automatically)
Once the PR is merged, you can delete your branch.

@hreintke
Copy link
Contributor Author

hreintke commented Aug 7, 2018

@devyte Will check in the coming days.
Need to make sure that I do loose other (local) updates I am using.

@hreintke
Copy link
Contributor Author

Superseded by #5024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants