Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwip2: use only wifi_station_get_hostname() to set netif hostname #4299

Merged
merged 4 commits into from
Feb 7, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Feb 5, 2018

fix #3970

@d-a-v d-a-v added this to the 2.4.1 milestone Feb 5, 2018
@d-a-v d-a-v requested a review from devyte February 6, 2018 17:57
@devyte
Copy link
Collaborator

devyte commented Feb 6, 2018

Add a comment above esp2glue_netif_update(), above esp2glue_dhcp_start(), and above other functions calling those, that the netif hostname will be set from wifi_station_get_hostname(), with the implication that the hostname must be set externally via wifi_station_set_hostname() before calling any of those functions.
Maybe put the same comment in the README, and other places it makes sense, i.e.: make it VERY visible, because I can feel issues in the future about the call order.

Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment about call order

@d-a-v
Copy link
Collaborator Author

d-a-v commented Feb 6, 2018

Comments added inside lwip2, stating that there is no other way than setting hostname before dhcp client is started by WiFi.begin() (as it turns out, independantly from lwip2).

@devyte devyte merged commit 0339bbb into esp8266:master Feb 7, 2018
@d-a-v d-a-v deleted the hostname branch February 7, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dhcp hostname issue in 2.4.0
2 participants