device test for #4516 (WiFiClient leaking) #4549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test needs any TCP server and tries to find one on the gateway.
20 tcp connections are made, heap is measured.
Might be improvable (python tcp server, better measurement?)
Problem is heap does not depend on the sketch only, even if one tries to keep it straight.
See the success run, measurement must not stop at the bad moment.
Also we cannot presume how much is lost on each loop (64 here).
The same test is good too with 200 connections instead of 20, se we could make averages that would lower glitches.
Suggestions are welcome.
failed run (without fix):
success run with fix (#4516):