Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defined SDA and SCL pins for Olimex MOD-WIFI-ESP8266(-DEV) #4562

Merged
merged 2 commits into from
Mar 26, 2018
Merged

defined SDA and SCL pins for Olimex MOD-WIFI-ESP8266(-DEV) #4562

merged 2 commits into from
Mar 26, 2018

Conversation

mabi
Copy link
Contributor

@mabi mabi commented Mar 25, 2018

Changed from generic I2C SDA and SCL pin mapping to specific mapping for board modwifi, Olimex MOD-WIFI-ESP8266(-DEV)

@devyte
Copy link
Collaborator

devyte commented Mar 25, 2018

@mabi boards.txt is generated by a tool, you need to modify the tool instead.

devyte
devyte requested changes Mar 25, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changes in boards.txt to board generator tool.

@mabi
Copy link
Contributor Author

mabi commented Mar 25, 2018

@devyte thank you for the explanation, I will fix shortly

@mabi
Copy link
Contributor Author

mabi commented Mar 25, 2018

@devyte I will shortly squash the commits in one

@d-a-v
Copy link
Collaborator

d-a-v commented Mar 26, 2018

@mabi
You need to regenerate boards.txt with the script and re-add/commit it.
CI also generates it and complains when result differs (yes this is minor diff :)

@mabi
Copy link
Contributor Author

mabi commented Mar 26, 2018

@d-a-v thank you very much, I didn't expect that that line would change place re-running the tool :-)
@devyte is this commit OK for your change request?

@devyte
Copy link
Collaborator

devyte commented Mar 26, 2018

Yes, but I'll let @d-a-v merge this 😝

@d-a-v d-a-v merged commit e1ca870 into esp8266:master Mar 26, 2018
@mabi mabi deleted the mabi/modwifi branch March 26, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabi @devyte @d-a-v