-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldscripts: a Makefile to change c++ vtables location #4567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple little things to make parsing the output easier and more flexible.
tools/sdk/ld/Makefile
Outdated
@echo " heap: move c++ vtables to heap" | ||
|
||
heap: | ||
@(echo "$(WARN)"; $(CPP) -E -DVTABLES_IN_DRAM $(COMMON).h | grep -v '^#') > $(COMMON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add in a -CC to preserve comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done for both
tools/sdk/ld/Makefile
Outdated
|
||
iram: | ||
@(echo "$(WARN)"; $(CPP) -E -DVTABLES_IN_IRAM $(COMMON).h | grep -v '^#') > $(COMMON) | ||
@echo "c++ vtables moved to iram" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-CC to preserve comments
Can you add a "flash:" branch, with the appropriate #if defined(VTABLES_IN_FLASH)
to the makefile and app.ld file as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer push as-is since it does not change current ldscripts alot (thanks to your -CC option I was not aware of).
So you can take it as yours and improve ldscripts like I'm not able to.
no need to add more options to the boards generator as previously proposed
eagle.app.v6.common.ld
is regenerated withmake iram
to be noted: cpp remove comments