Skip to content

WebServer query arguments not containing an equals sign are now accepted… #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

WebServer query arguments not containing an equals sign are now accepted… #4573

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bfc1900
WebServer query arguments not containing an equals sign are now accep…
jasonharper Mar 26, 2018
fbcd361
Merge branch 'master' into master
jasonharper Mar 26, 2018
639ef4f
Merge branch 'master' into master
jasonharper Mar 27, 2018
d03be14
Merge branch 'master' into master
jasonharper Mar 28, 2018
cabced2
Merge branch 'master' into master
jasonharper Apr 2, 2018
94465dc
Merge branch 'master' into master
jasonharper Apr 3, 2018
0bb48e0
Merge branch 'master' into master
jasonharper Apr 7, 2018
485b921
Merge branch 'master' into master
jasonharper Apr 9, 2018
0505675
Merge branch 'master' into master
earlephilhower Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions libraries/ESP8266WebServer/src/Parsing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,19 +311,13 @@ void ESP8266WebServer::_parseArguments(String data) {
DEBUG_OUTPUT.print(" &@ ");
DEBUG_OUTPUT.println(next_arg_index);
#endif
RequestArgument& arg = _currentArgs[iarg];
if ((equal_sign_index == -1) || ((equal_sign_index > next_arg_index) && (next_arg_index != -1))) {
#ifdef DEBUG_ESP_HTTP_SERVER
DEBUG_OUTPUT.print("arg missing value: ");
DEBUG_OUTPUT.println(iarg);
#endif
if (next_arg_index == -1)
break;
pos = next_arg_index + 1;
continue;
arg.key = urlDecode(data.substring(pos, next_arg_index));
} else {
arg.key = urlDecode(data.substring(pos, equal_sign_index));
arg.value = urlDecode(data.substring(equal_sign_index + 1, next_arg_index));
}
RequestArgument& arg = _currentArgs[iarg];
arg.key = urlDecode(data.substring(pos, equal_sign_index));
arg.value = urlDecode(data.substring(equal_sign_index + 1, next_arg_index));
#ifdef DEBUG_ESP_HTTP_SERVER
DEBUG_OUTPUT.print("arg ");
DEBUG_OUTPUT.print(iarg);
Expand Down