Allow other ESP debug port class types #4611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is that I have implemented an alternative
DEBUG_ESP_PORT
object inheriting from thePrint
class, so that I can embed the debug output in our own framing method by overriding the lowest-levelwrite()
functions. The pointer comparison added in #4467 broke the ability to provide a different object type. Casting to void pointers before the comparison restores that ability.My use case basically looks like:
I'll admit it's not as ideal as making the
HardwareSerial
class more inheritable, but it does function well.