Added channel, ssid scan #4636
Merged
Added channel, ssid scan #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overloaded scanNetworks so scan can occur on a single channel and/or for a particular ssid.
devyte
requested changes
Apr 11, 2018
|
|
||
| struct scan_config config; | ||
| memset(&config, 0, sizeof(config)); | ||
| config.ssid = ssid; |
There was a problem hiding this comment.
The only difference between the original method and your overloaded one are these two lines:
config.ssid = ssid;
config.channel = channel;
where ssid and channel are new arguments.
Instead of duplicating the entire method, please just add the two arguments to the original method, and in the .h put set default values to keep the current behavior (i.e.: channel = 0 and ssid = nullptr, because of the memset).
channel number and ssid have been added as optional parameters to the orginal scanNetworks()
devyte
approved these changes
Apr 12, 2018
|
Is it now possible to scan only specific ssid. If so how to do it? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overloaded scanNetworks so scan can occur on a single channel and/or for a particular ssid.
I needed this so I could speed up the scan time in order to track the location of a mobile device using the measured signal strength. A three-second scan was too long. With this modification, the scan time is reduced to ~100 mS if the channel number is defined.
If folks find this useful, I might also fool around with the scan time parameter.
I hope that you will consider including this modification in the next release version.