-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lwip2: fix static address management #4677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to comment on leftover if 1
and if 0
preprocessor blocks in lwip-builder, but GitHub doesn't let me do this for some reason. Other changes LGTM.
Is it possible to come up with a test case for static IP assignment, or too complex?
@igrr that's because the code is really in the other repo.
|
@igrr there is no lwIP api to check whether dhcp is running (or I could not find it), so yes I currently don't know how I could make a device test with this. @devyte thanks to pinpoint. The "lwip2" repo is for esp8266-nonos-sdk only. lwIP -the real upstream library- is a sub-module (hence a sub-sub-module of the arduino core) and is not held in the "lwip2" repo. "lwip2" is only the glue between esp8266-nonos-sdk and upstream lwIP hosted on savannah. |
remove dead code add (*phy_capture)() for input/output packet capture add lwip_unhandled_packet() weak empty function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing jumps out at me, so approving.
No description provided.