Fixed SSID length limit to 32 bytes #4691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgesser Thanks! However, this PR is incomplete. There are other places where ssid is used, which need to be modified.
There may be other places. A thorough search of code that sets/gets/uses the ssid must be done. Also, there is the SoftAP ssid to consider in ESP8266WiFiAP.cpp. And having said that, I just realized that 64-char passphrase is not supported for SoftAP. Not sure if it makes sense, though. |
devyte
requested changes
Apr 28, 2018
|
Closing in favor of #5411 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wifi was rejecting connections for SSID with 32 bytes.
It was also returning trash bytes at the end of SSIDs when scanning ...