Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lwip2 fix and update #4729

Merged
merged 8 commits into from
May 25, 2018
Merged

lwip2 fix and update #4729

merged 8 commits into from
May 25, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented May 14, 2018

  • avoid crash when IP address is set to 0(any) by dhcp not getting its lease renewal in due time
  • automatically remove oldest PCBs in time-wait state, limit their number (thanks to @me-no-dev)
    and update faq update about tcpCleanup()
  • update an option in the interactive example to go back to DHCP client mode from static mode
  • add a macro HAS_PHY_CAPTURE=1 indicating capture facility is available

devyte
devyte approved these changes May 14, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d-a-v added 3 commits May 17, 2018 14:12
@d-a-v
interactive example update with re-setting IP by dhcp
715eccb
@d-a-v
lwIP-v2: update & fix (see below)
cb26352 
* avoid crash when IP address is set to 0(any) by dhcp not getting its lease renewal in due time
* automatically remove oldest PCBs in time-wait state, limit their number
  thanks to @me-no-dev esp8266@07f4d4c#diff-f8258e71e25fb9985ca3799e3d8b88ecR399
* add a macro HAS_PHY_CAPTURE=1 indicating capture facility is available
@d-a-v
faq update about tcpCleanup()
07d2a0b
@d-a-v d-a-v mentioned this pull request May 17, 2018
Closed
6 tasks
@d-a-v
Copy link
Collaborator Author

d-a-v commented May 18, 2018

I just manually rebased. Looks like #4737 is now required.

The job exceeded the maximum time limit for jobs, and has been terminated.

@d-a-v d-a-v merged commit 1a9403d into esp8266:master May 25, 2018
@d-a-v d-a-v deleted the interactive branch May 25, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @devyte