Skip to content

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 13, 2018

ref: #2677
SPI::transferBytes_() needs 32bits optimization in its input part, like the one in its output part (done)

* @param out uint8_t *
* @param in uint8_t *
* @param size uint8_t (max 64)
*/
void SPIClass::transferBytes_(const uint8_t * out, uint8_t * in, uint8_t size) {
while(SPI1CMD & SPIBUSY) {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest an ASSERT() here checking the alignment of the inputs would be handy here and print a useful error when debugging was enabled...

@devyte
Copy link
Collaborator

devyte commented Jul 27, 2018

Assert and optimization will be tracked with an issue. Merging this.

@devyte devyte merged commit 3cc12b1 into esp8266:master Jul 27, 2018
@devyte devyte mentioned this pull request Jul 27, 2018
6 tasks
@d-a-v d-a-v deleted the spitransfer branch August 1, 2018 20:54
@d-a-v d-a-v added this to the 2.4.2 milestone Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants