Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XinaBox #4929

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Add support for XinaBox #4929

merged 2 commits into from
Jul 17, 2018

Conversation

brendanvanbreda
Copy link
Contributor

Add support for the XinaBox CW01.

Information of the product can be found on our store.
Additional info can be found on our wiki.

Add support for the XinaBox CW01;
@brendanvanbreda
Copy link
Contributor Author

@d-a-v , did all the steps you previously mentioned, hopefully without any errors.

@brendanvanbreda
Copy link
Contributor Author

@d-a-v not sure on what is causing the BUILD_TYPE=host_tests to fail, any ideas ?

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, much better than the previous attempt!

@earlephilhower earlephilhower added this to the 2.4.2 milestone Jul 17, 2018
@earlephilhower
Copy link
Collaborator

See no reason why this couldn't be in the upcoming 2.4.2 at very low risk.

@earlephilhower earlephilhower merged commit e5648f3 into esp8266:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants