Include SetUUID for SSDP #4981
Include SetUUID for SSDP #4981
Conversation
Inclusion of the SetUUID Method for Custom UUID
| "<modelURL>%s</modelURL>" | ||
| "<manufacturer>%s</manufacturer>" | ||
| "<manufacturerURL>%s</manufacturerURL>" | ||
| "<UDN>UUID: %s</UDN>" |
There was a problem hiding this comment.
The text uuid changed to uppercase and a space was added after the colon. Is that on purpose?
There was a problem hiding this comment.
No specific purpose, just aesthetic.
It gets sharper for technical support information.
| @@ -39,7 +39,7 @@ class UdpContext; | |||
| #define SSDP_SCHEMA_URL_SIZE 64 | |||
| #define SSDP_DEVICE_TYPE_SIZE 64 | |||
| #define SSDP_FRIENDLY_NAME_SIZE 64 | |||
| #define SSDP_SERIAL_NUMBER_SIZE 32 | |||
| #define SSDP_SERIAL_NUMBER_SIZE 37 | |||
There was a problem hiding this comment.
Is this change on purpose? If so, could you please explain?
There was a problem hiding this comment.
I increased to support larger serial numbers.
When I was testing, I felt this need.
Depending on the manufacturer, the serial number format may be somewhat similar to UUID in size.
libraries/ESP8266SSDP/ESP8266SSDP.h
Outdated
| void setDeviceType(const String& deviceType) { setDeviceType(deviceType.c_str()); } | ||
| void setDeviceType(const char *deviceType); | ||
| void setName(const String& name) { setName(name.c_str()); } | ||
| void setUUID(const String& uuid) { setUUID(uuid.c_str()); } |
There was a problem hiding this comment.
Please add a comment that this must be called before begin() for user-specified uuid.
There was a problem hiding this comment.
Done, make comment
There was a problem hiding this comment.
| "<manufacturer>%s</manufacturer>" | ||
| "<manufacturerURL>%s</manufacturerURL>" | ||
| "<UDN>uuid:%s</UDN>" | ||
| "</device>" |
There was a problem hiding this comment.
I'm not 100% sure, but I believe these were left here in case a user wants to add a specific icon. It's not the best way to do it, but until a better way is implemented I'd rather keep these lines.
There was a problem hiding this comment.
I'm not 100% right either. As the code was commented, I found it appropriate to remove, but no problem to maintain. You decide.
There was a problem hiding this comment.
Normally I'd agree, or I'd even request the removal myself, but I think this should be an exception. Please keep it for now, I consider this technical debt.
Inclusion of the SetUUID Method for Custom UUID