Wrong directory for installation?? #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLEASE REVIEW, I'm not completely sure, but on Linux there's no `hardware` directory inside `Java`, and it doesn't seem to make sense that there should be on MacOS. There is, instead, a `hardware` directory in the parent.
d-a-v
approved these changes
Sep 25, 2018
|
Thanks @teo1978 |
|
The old version (one with Java) looks correct for MacOS version of Arduino, IMO. I think this should be reverted. |
|
It's not correct for Linux, and I checked on Linux. In that case, they should be specified individually. Also, I think it shouldn't even be inside the Arduino application directory, but rather in the arduino dir. I'll revert and edit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE REVIEW, I'm not completely sure, but on Linux there's no
hardwaredirectory insideJava, and it doesn't seem to make sense that there should be on MacOS. There is, instead, ahardwaredirectory in the parent.