-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dns server cleanup #5194
Dns server cleanup #5194
Conversation
Just a note, @Makuna, you can keep a PR open and just |
@earlephilhower I tried that, but the PR would not update. Not sure what was going on; but it would not allow to re-run the tests and the update branch was greyed out. |
Also, Since I am the author of this change, I feel other collaborators should review and merge. Is that the normal policy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
// name size cold be easily contained without a reallocation | ||
// - max size would be 253, in 2013, average is 11 and max was 42 | ||
// | ||
parsedDomainName.reserve(32); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! String::reserve() examples are few and far between.
@@ -6,6 +6,8 @@ | |||
#define DNS_QR_RESPONSE 1 | |||
#define DNS_OPCODE_QUERY 0 | |||
|
|||
#define MAX_DNSNAME_LENGTH 253 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used anywhere as far as I can see, but shouldn't do any harm.
No description provided.