Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore spiffs data in boards.txt #5195

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Sep 30, 2018

(removed by mistake)

@earlephilhower
Copy link
Collaborator

This fixes my issue uploading SPIFFS.

Trying an upload with a 4M (no SPIFFS) setting, which should error, gives:

[SPIFFS] data   : /home/earle/Arduino/BearSSL_CertStore1/data
[SPIFFS] size   : -20
[SPIFFS] page   : 256
[SPIFFS] block  : 8192
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

SPIFFS Create Failed!

With the removed if spiffs_kb>0, though, it would give a slightly more informative error
SPIFFS Not Defined for LOLIN(WEMOS) D1 R2 & mini, 80 MHz, Flash, 4M (no SPIFFS), v2 Lower Memory, Disabled, None, Only Sketch, 921600

Really a matter of preference, since it's an error and both are pretty obvious when you look at them.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed my issue/

tools/boards.txt.py Show resolved Hide resolved
@devyte devyte merged commit 88d0a15 into esp8266:master Oct 1, 2018
@d-a-v d-a-v deleted the boardspiffs branch October 2, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants