Bugfix/esp8266 http client #5220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2018 18:29
…ject on the heap in stead of stack
6 tasks
earlephilhower
requested changes
Oct 11, 2018
earlephilhower
approved these changes
Oct 11, 2018
|
@earlephilhower I looked at the diff and see that everywhere _canReuse is set to false just before the call to ::end(). But ::end() also sets _canReuse to false. It doesn't harm, but it isn't necessary. I create another PR. |
suculent
pushed a commit
to thinx-cloud/Arduino
that referenced
this pull request
Oct 16, 2018
…Arduino into i2c_slave_by_bjoham * 'i2c_slave_by_bjoham' of https://github.com/thinx-cloud/Arduino: Update debugging.rst (esp8266#5234) ESP8266httpClient crash-on-destructor bugfix (esp8266#5220) Add stack repainting call to ESP class (esp8266#5221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #5216 + minor changes: removing unnecessary tests and make sure that end() also closes the connection if it was a Keep-Alive connection.
Changed BasicHttpsClient.ino to also allocate the BearSSL::WiFiClientSecure on the heap in stead of on the stack.