Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack repainting call to cont_utils #5221

Merged
merged 3 commits into from
Oct 11, 2018

Conversation

earlephilhower
Copy link
Collaborator

Allow the unused stack to be reset to the check value at any time in
the application, allowing for delta-stack calculations to be done.

Add in some dumping in the BearSSL_Validation example to show the
usage for those that care.

Allow the unused stack to be reset to the check value at any time in
the application, allowing for delta-stack calculations to be done.

Add in some dumping in the BearSSL_Validation example to show the
usage for those that care.
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hide these functions behind methods implemented in ESPClass, similar as for stack use. And then remove the include cont.h.

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful debugging helper, I agree this could be included in ESP API.

@earlephilhower
Copy link
Collaborator Author

Added an ESP class helper, and am now using it in the example.

@earlephilhower earlephilhower merged commit 1b1b0a2 into esp8266:master Oct 11, 2018
@earlephilhower earlephilhower deleted the paintstack branch October 11, 2018 15:55
suculent pushed a commit to thinx-cloud/Arduino that referenced this pull request Oct 16, 2018
…Arduino into i2c_slave_by_bjoham

* 'i2c_slave_by_bjoham' of https://github.com/thinx-cloud/Arduino:
  Update debugging.rst (esp8266#5234)
  ESP8266httpClient crash-on-destructor bugfix (esp8266#5220)
  Add stack repainting call to ESP class (esp8266#5221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants